Skip to content

BUG: Timedelta == ndarray[td64] #33441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2020
Merged

BUG: Timedelta == ndarray[td64] #33441

merged 2 commits into from
Apr 10, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

xref #33346

Between the two of these, we should be able to get rid of this kludge: https://github.com/pandas-dev/pandas/blob/master/pandas/core/internals/managers.py#L629

IIRC there were some test_coercion xfails related to that kludge, will be worth revisiting.

@jbrockmendel jbrockmendel mentioned this pull request Apr 10, 2020
Merged
jreback
jreback requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have tests for NaT (object and inside the ndarray and 0-dim?

@jbrockmendel
Copy link
Member Author

do we have tests for NaT (object and inside the ndarray and 0-dim?

no, i have the 0-d case in my notes for a follow-up

@jreback jreback added this to the 1.1 milestone Apr 10, 2020
@jreback jreback added the Timedelta Timedelta data type label Apr 10, 2020
@jreback jreback merged commit fe42954 into pandas-dev:master Apr 10, 2020
@jreback
Copy link
Contributor

jreback commented Apr 10, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-td-cmp branch April 10, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Bug Timedelta Timedelta data type
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @jorisvandenbossche